Remove --non-zero-exit-on-violation option #152
Merged
+1
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for 3.0 really, its a breaking change in the pipeline especially for incremental analysis |
|
@exussum12 yup, everything what I'm going to do now is for 3.0 :) |
exussum12
approved these changes
Dec 15, 2021
|
Thanks @exussum12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drop support of
--non-zero-exit-on-violationoption.The argument is: phpmnd is mostly used in CI where it must fail builds in case any violation is detected so it does not make a lot of sense to use in CI and skip violations.