This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Uni-Stark Challenges #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
force-pushed
the
uni-stark-with-fixed
branch
from
d4b67d7
to
b4ef43a
Compare
Schaeff
reviewed
Aug 8, 2024
Schaeff
force-pushed
the
uni-stark-challenges-2
branch
from
fedcda6
to
16d55a3
Compare
georgwiese
reviewed
Sep 16, 2024
uni-stark/src/proof.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize)] | ||
| pub struct Commitments<Com> { | ||
| pub(crate) trace: Com, | ||
| pub(crate) stages: Vec<Com>, |
There was a problem hiding this comment.
Suggested change
| pub(crate) stages: Vec<Com>, | |
| pub(crate) traces_by_stage: Vec<Com>, |
uni-stark/src/proof.rs
Outdated
Comment on lines
42
to
43
| pub(crate) stages_local: Vec<Vec<Challenge>>, | ||
| pub(crate) stages_next: Vec<Vec<Challenge>>, |
There was a problem hiding this comment.
Hmm, again, I would still include "trace" in the name. traces_by_stage_local?
There was a problem hiding this comment.
I guess that's more a general comment: What's a stage? To me it's just a number, for anything else I think it would be better to give a more specific name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for challenges: main additions will include
prove()intorun_stage()andfinish()to handle higher stage trace generation.NextStageTraceCallbackandCommittedDatato handle multiple traces.Folder,check_constraints, andSymbolicAirBuilderfor compatibility with assertions over traces of different stages.