Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1406] Fix zIndex Global Prop Issues in Playbook (and Nitro) #3545

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

kangaree
Copy link
Contributor

@kangaree kangaree commented Jul 23, 2024

What does this PR do?

  • ✅ Change Fixed Toast's z-index from $z_9 to the max, $z_10.
  • ✅ Use variables instead of hardcoded z-index values (and w/ responsive)
  • ✅ Use important tag with z-indexes

Note: This doesn't actually fix the Fixed Toast appearing below in Nitro. For that fix, the changes must be made in Nitro: PR.

How to test? Steps to confirm the desired behavior:

  1. Go to https://pr3545.playbook.beta.hq.powerapp.cloud/visual_guidelines/z_index
  2. Check out the visual guide. The larger the number for the z token is, the higher the div should be.
  3. Go to https://pr3545.playbook.beta.hq.powerapp.cloud/kits/fixed_confirmation_toast/react#click-to-show-positions
  4. Make sure all the positions work
  5. Go to https://codesandbox.io/p/sandbox/holy-grass-4pqgz7?file=%2Fsrc%2FApp.js
  6. Change the width. A "md and above" div should be on top on medium devices or wider. Otherwise a "sm and below" div is on top.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@kangaree kangaree added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Jul 23, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.33.1.pre.alpha.PLAY14063320

Your Alpha for NPM is 13.33.1-alpha.PLAY14063320

@kangaree kangaree added enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) labels Jul 25, 2024
@kangaree kangaree marked this pull request as ready for review July 25, 2024 14:25
@kangaree kangaree requested review from a team as code owners July 25, 2024 14:25
@kangaree kangaree removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 31, 2024
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Aug 9, 2024
@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Aug 12, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Aug 12, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 0827d8a Aug 13, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1406 branch August 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants