Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-258] NEW Pagination kit in React #3552

Merged
merged 18 commits into from
Aug 23, 2024
Merged

[PBNTR-258] NEW Pagination kit in React #3552

merged 18 commits into from
Aug 23, 2024

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Jul 25, 2024 •
edited
Loading

This PR adds the Pagination kit in react

Screenshot 2024-08-09 at 9 18 12 AM

How to test? Steps to confirm the desired behavior:

  1. Go to 'the pagination kit and test it

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Jul 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.34.1.pre.alpha.pbntr258paginationkitforreact3404

Your Alpha for NPM is 13.34.1-alpha.pbntr258paginationkitforreact3404

@nickamantia nickamantia added alpha and removed alpha labels Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.34.1.pre.alpha.pbntr258paginationkitforreact3409

Your Alpha for NPM is 13.34.1-alpha.pbntr258paginationkitforreact3409

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Aug 8, 2024
@nickamantia nickamantia added alpha and removed milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.34.1.pre.alpha.pbntr258paginationkitforreact3411

Your Alpha for NPM is 13.34.1-alpha.pbntr258paginationkitforreact3411

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-258-pagination-kit-for-react

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Aug 8, 2024
@nickamantia nickamantia added alpha and removed alpha labels Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.34.1.pre.alpha.pbntr258paginationkitforreact3413

Your Alpha for NPM is 13.34.1-alpha.pbntr258paginationkitforreact3413

@nickamantia nickamantia added the new kit Use this when adding a new kit to Playbook (USED IN CHANGELOG) label Aug 9, 2024
@nickamantia nickamantia marked this pull request as ready for review August 9, 2024 13:23
@nickamantia nickamantia requested review from a team as code owners August 9, 2024 13:23
@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Aug 16, 2024
ElisaShapiro
ElisaShapiro approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ElisaShapiro ElisaShapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📄 looks great!

nidaqg
nidaqg approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@nidaqg nidaqg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! There's a little bit of glitchiness in the UI when clicking through the pages, let's get a follow up story to look into addressing it @nickamantia cc: @jasperfurniss

@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Aug 22, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit 378069b Aug 23, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the pbntr-258-pagination-kit-for-react branch August 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElisaShapiro ElisaShapiro ElisaShapiro approved these changes

@nidaqg nidaqg nidaqg approved these changes

@carloslimasd carloslimasd carloslimasd approved these changes

Assignees

@nickamantia nickamantia

Labels
alpha Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano new kit Use this when adding a new kit to Playbook (USED IN CHANGELOG) Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickamantia @carloslimasd @nidaqg @ElisaShapiro @jasperfurniss