-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-371] [3 of 4] Star Rating kit: add styles and animation #3566
Merged
jasperfurniss
merged 16 commits into
master
from
PBNTR-371-star-rating-interactive-animation
Aug 13, 2024
Merged
[PBNTR-371] [3 of 4] Star Rating kit: add styles and animation #3566
jasperfurniss
merged 16 commits into
master
from
PBNTR-371-star-rating-interactive-animation
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElisaShapiro
added
the
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
label
Aug 2, 2024
ElisaShapiro
added
the
milano
20 MAX - Deploy this PR to a review environment via Milano
label
Aug 5, 2024
ElisaShapiro
added
milano
20 MAX - Deploy this PR to a review environment via Milano
and removed
milano
20 MAX - Deploy this PR to a review environment via Milano
labels
Aug 6, 2024
nidaqg
previously approved these changes
Aug 12, 2024
nidaqg
added
Code Approved
Approved by a Playbook Admin
Product Approved
pending technical review, OK to merge to master
labels
Aug 12, 2024
…com:powerhome/playbook into PBNTR-371-star-rating-interactive-animation
jasperfurniss
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Approved
Approved by a Playbook Admin
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Product Approved
pending technical review, OK to merge to master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-371 adds styling from star rating kit handoff to enhance interactive star rating kit (rails version creation ticket, react version creation ticket). This PR adds state managed hover styles, focus styles, adds the dark mode
primary
star style, and ensures that the PbEnhancedElement code for this kit was added to the new playbook-rails.js created in the recent switch to vite. It reveals the previously created rails and react interactive doc examples, and also adds an interactive star rating kit to the first form doc example.Screenshots: Screenshots to visualize your addition/change
Rails interactive star rating kit - see selected stars, hover stars, and focus box via keyboard-tabbing
React interactive star rating kit - see selected stars, hover stars, and focus box via keyboard-tabbing
Rails interactive star rating kit on form doc example
Primary star in dark mode (first photo shows current production, where dark mode primary star is still $primary; second photo shows it updated to $active_dark)
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.- [ ] TESTS I have added test coverage to my code.