[PLAY-1463] Linter: Kits T - W (except Typeahead) #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add return type (@typescript-eslint/explicit-module-boundary-types) Ignore multiple components in one file for now (react/no-multi-comp) Use const appropiately (prefer-const)
Indent properly (react/jsx-closing-bracket-location) Define before use (no-use-before-define)
Remove default empty callback (@typescript-eslint/no-empty-function) Fill in types (no-explicit-any) Define before use (no-use-before-define) Indent properly (react/jsx-indent-props) Break out multi props from one liner (react/jsx-max-props-per-line) Add return type (@typescript-eslint/explicit-module-boundary-types)
Add return type (@typescript-eslint/explicit-module-boundary-types) Indent properly (react/jsx-indent-props)
Ignore "'JSX' is not defined"
Add return type (@typescript-eslint/explicit-module-boundary-types) Indent properly (react/jsx-indent-props)
Set children prop type to ReactNode (jsx-control-statements/jsx-jcs-no-undef) Fill in types (no-explicit-any)
Add missing deps and merge in useState (react-hooks/exhaustive-deps) Allow console messages in test (no-console) Add return type (@typescript-eslint/explicit-module-boundary-types)
Fill in types (no-explicit-any) Add return type (@typescript-eslint/explicit-module-boundary-types) Ignore unusedVar for onMultiValueClick cb (@typescript-eslint/no-unused-vars) Add missing deps (react-hooks/exhaustive-deps) Indent properly (react/jsx-indent-props) Ignore multiple components in one file for now (react/no-multi-comp) Define before use (no-use-before-define) Define debouncedSearch function shape (@typescript-eslint/ban-types) Use let appropriately
Add return type (@typescript-eslint/explicit-module-boundary-types) Indent properly (react/jsx-indent-props)
Use Record<string, unknown> not object (@typescript-eslint/ban-types) Add missing display name (react/display-name) Indent properly (react/jsx-indent-props) Add return type (@typescript-eslint/explicit-module-boundary-types) Ignore multiple components in one file for now (react/no-multi-comp)
Add return type (@typescript-eslint/explicit-module-boundary-types)
@typescript-eslint/no-explicit-any @typescript-eslint/explicit-module-boundary-types react/prop-types Focus on errors and small changes for warnings. Consider making these big changes in a separate story.
This reverts commit 0554482.
kangaree
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.34.1.pre.alpha.PLAY14633399 Your Alpha for NPM is 13.34.1-alpha.PLAY14633399 |
jasperfurniss
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How to test?
We've already tested PLAY-1086 with an alpha.
We're going to retest everything except for Typeahead. See the story.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.