Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1411] Badge Notification Error Variant #3596

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

kangaree
Copy link
Contributor

@kangaree kangaree commented Aug 14, 2024

What does this PR do?

  • ✅ Add a notification error variant that's opaque and red
  • ✅ Use $error in non-dark mode. Use $error_dark in dark mode.
  • ✅ Update docs and testing

Screenshots:

Screenshot 2024-08-14 at 9 47 05 AM Screenshot 2024-08-15 at 1 11 24 PM

How to test?

  1. Go to kits/badge/react#notification
  2. Make sure the error notification badge is the same as a notification badge, but with a different color
  3. Turn on dark mode. The badge color should be red, but better suited for dark mode.
  4. Make sure that the normal "colors" are not affected.
  5. Repeat the above, but with Rails

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@kangaree kangaree added enhancement New Features, Props, & Variants (USED IN CHANGELOG) alpha labels Aug 14, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.0.0.pre.alpha.PLAY14113475

Your Alpha for NPM is 14.0.0-alpha.PLAY14113475

Remove duplicate color style
@kangaree kangaree added milano 20 MAX - Deploy this PR to a review environment via Milano and removed alpha labels Aug 15, 2024
@kangaree kangaree marked this pull request as ready for review August 15, 2024 18:18
@kangaree kangaree requested review from a team as code owners August 15, 2024 18:18
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Aug 16, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Aug 21, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit 4b01b9d Aug 23, 2024
8 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1411 branch August 23, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants