Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-415] Adding Star Rating form controls #3600

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Aug 15, 2024

What does this PR do?
Adding Star Rating form controls

How to test? Steps to confirm the desired behavior:

  1. Go to the Form kit page
  2. Scroll down to the last input (Star Rating kit)

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Aug 15, 2024
@carloslimasd carloslimasd self-assigned this Aug 15, 2024
@carloslimasd carloslimasd requested review from a team as code owners August 15, 2024 16:04
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.0.0.pre.alpha.PBNTR415starratingform3492

Your Alpha for NPM is 14.0.0-alpha.PBNTR415starratingform3492

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.0.0.pre.alpha.PBNTR415starratingform3493

Your Alpha for NPM is 14.0.0-alpha.PBNTR415starratingform3493

Copy link
Contributor

@ElisaShapiro ElisaShapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 great work on adding the wrapper!

@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Aug 21, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Aug 21, 2024
@nidaqg nidaqg added this pull request to the merge queue Aug 23, 2024
Merged via the queue into master with commit 4b051ec Aug 23, 2024
8 checks passed
@nidaqg nidaqg deleted the PBNTR-415-star-rating-form branch August 23, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants