Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fills the metadata attribute, in the get NAD's output #878

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

CBiasuzzi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

no

What kind of change does this PR introduce?

feature

What is the current behavior?

In addition to the NAD's SVG, the NAD's metadata is used by some visualization tools developed with pypowsybl.
However, the current Network.get_network_area_diagram method returns an instance of Svg where the metadata attribute is always None.

What is the new behavior (if this is a feature change)?

The output Svg's 'metadata' attribute is now set with the NAD metadata.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…ngs; fills the metadata attribute in the get_network_area_diagram's output Svg (python side)

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
python test

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
@CBiasuzzi CBiasuzzi changed the title [WIP] Fills the metadata attribute, in the get NAD's output Fills the metadata attribute, in the get NAD's output Oct 30, 2024
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Failed Quality Gate failed for 'pypowsybl'

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Nov 4, 2024

@geofjamg geofjamg merged commit 07475b7 into main Nov 4, 2024
8 checks passed
@geofjamg geofjamg deleted the adds_metadata_to_get_nad_output branch November 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants