Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bus/Breaker view buses: add column with bus ID in bus view #880

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Oct 29, 2024

🚧 WIP only because to be merged after #881

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

this comment: #497 (comment)

What kind of change does this PR introduce?

Feature

What is the current behavior?

Getting the relation of a bus in bus/breaker view to a bus in bus view requires using Network.get_bus_breaker_topology(voltage_level_id). When we need this link for thousands of voltage levels then the performance is poor.

What is the new behavior (if this is a feature change)?
Network.get_bus_breaker_view_buses() now return additional column bus_id containing the bus ID in the bus view for the bus in the bus/breaker view.

Does this PR introduce a breaking change or deprecate an API?

  • No

Other information:

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged jeandemanged changed the base branch from main to fix-bb-topology-no-connected-terminal November 1, 2024 23:51
@jeandemanged jeandemanged changed the title Bus/Breaker view buses: add column with bus ID in bus view [WIP] Bus/Breaker view buses: add column with bus ID in bus view Nov 1, 2024
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Copy link

sonarcloud bot commented Nov 1, 2024

Copy link

sonarcloud bot commented Nov 2, 2024

Base automatically changed from fix-bb-topology-no-connected-terminal to main November 7, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant