Skip to content

Commit

Permalink
Modernize and simplify iris.analysis._Groupby (SciTools#5015)
Browse files Browse the repository at this point in the history
* Modernize and simplify _Groupby

* Rename variable to improve readability

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>

* Add a whatsnew entry

* Add a type hint to _add_shared_coord

* Add a test for iris.analysis._Groupby.__repr__

---------

Co-authored-by: Martin Yeo <40734014+trexfeathers@users.noreply.github.com>
  • Loading branch information
2 people authored and pp-mo committed Apr 13, 2023
1 parent c4e8bbb commit e6661b8
Show file tree
Hide file tree
Showing 4 changed files with 127 additions and 206 deletions.
3 changes: 3 additions & 0 deletions docs/src/whatsnew/latest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,9 @@ This document explains the changes made to Iris for this release
💼 Internal
===========

#. `@bouweandela`_ and `@trexfeathers`_ (reviewer) modernized and simplified
the code of ``iris.analysis._Groupby``. (:pull:`5015`)

#. `@fnattino`_ changed the order of ``ncgen`` arguments in the command to
create NetCDF files for testing (caused errors on OS X). (:pull:`5105`)

Expand Down
Loading

0 comments on commit e6661b8

Please sign in to comment.