WiP: in-Python documentation #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathunstrom
previously requested changes
Jan 19, 2019
|
@pathunstrom Would have been nice to have feedback in #109 when that was suggested (2 days ago) rather than once I started... What is the alternative you suggest? Maintaining all documentation in two places? |
|
I'm ok with removing the documentation from the readme if it's available elsewhere online. The readme only needs a summary in that case (eg, full API docs produced with Sphinx). |
|
@pathunstrom OK, is this the next #85? Should I just disregard the negative review and go with Jamie's recommendation? |
Merged
|
Rebased to solve the merge conflict. |
|
Obsoleted by #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
READMEto docstrings.VectorLikeorRealish.README.