Pickle support #147
Merged
Pickle support #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbraud
requested changes
Apr 14, 2019
| @@ -156,6 +156,9 @@ def __new__(cls, *args, **kwargs): | |||
|
|
|||
| return self | |||
|
|
|||
| def __reduce__(self): | |||
| return type(self).__new__, (type(self), self.x, self.y) | |||
There was a problem hiding this comment.
Will that prevent subclasses (esp. ones that add attributes) to be pickled correctly?
There was a problem hiding this comment.
The improved test answers this positively, in the case of subclasses without extra attributes.
I guess it would make sense to punt the with-attributes case to #144.
There was a problem hiding this comment.
The pickle docs mention higher-level protocols, but they're not actually implemented by the core stuff? not super clear.
nbraud
requested changes
Apr 15, 2019
Co-Authored-By: astronouth7303 <jamie@ivyleav.es>
nbraud
approved these changes
Apr 15, 2019
|
bors r+ |
Build succeeded
|
nbraud
added a commit
to nbraud/ppb-vector
that referenced
this pull request
Apr 15, 2019
nbraud
added a commit
to nbraud/ppb-vector
that referenced
this pull request
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for pickling.