Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector2: Add __radd__ #151

Merged
merged 3 commits into from
May 25, 2019
Merged

Vector2: Add __radd__ #151

merged 3 commits into from
May 25, 2019

Conversation

AstraLuma
Copy link
Member

Just a simple thing to enable <VectorLike> + <Vector>.

nbraud
nbraud requested changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing tests.

ppb_vector/vector2.py Outdated Show resolved Hide resolved
@nbraud
Copy link
Collaborator

nbraud commented May 22, 2019 •
edited
Loading

@astronouth7303 I implemented my requested changes.
Please take a look, and feel free to mark as approved by me (bors r=nbraud) if the changes are fine.

@nbraud
Copy link
Collaborator

nbraud commented May 22, 2019

PS: Please merge after #149; I'd rather deal with a merge conflict here rather than there.

@nbraud
Copy link
Collaborator

nbraud commented May 22, 2019

@astronouth7303 OK, this should be good to go.
Please run bors r=nbraud if you are happy with it.

@nbraud
Copy link
Collaborator

nbraud commented May 25, 2019

pokes @astronouth7303.

@AstraLuma
Copy link
Member Author

bors r=nbraud

bors bot added a commit that referenced this pull request May 25, 2019
@bors @AstraLuma @nbraud
Merge #151
343b634 
151: Vector2: Add __radd__ r=nbraud a=astronouth7303

Just a simple thing to enable `<VectorLike> + <Vector>`.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented May 25, 2019

Build succeeded

  • docs
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit 1731117 into master May 25, 2019
@nbraud nbraud deleted the add-radd branch May 25, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @nbraud