Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to Release Candidate 1 #175

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Bump version to Release Candidate 1 #175

merged 1 commit into from
Jun 26, 2019

Conversation

AstraLuma
Copy link
Member

No major bugs have cropped up, just some optional lapses in functionality.

@nbraud
Copy link
Collaborator

nbraud commented Jun 26, 2019

@astronouth7303 Can we merge #176 first? It addresses the last bit of feedback that was given on #23.

PS: Are the “optional lapses in functionality” documented somewhere? I assume this isn't addressed yet, since the only changes since 1.0b1 is my documentation PR (#173).

@AstraLuma
Copy link
Member Author

AstraLuma commented Jun 26, 2019

Things like #168, #171, and #174. These are improvements and expansions to the API that aren't part of any MVP or other functionality goals, and don't affect existing functionality. In other words, they're perfect for inclusion in a minor release.

@nbraud
Copy link
Collaborator

nbraud commented Jun 26, 2019

@astronouth7303 Ah, yes.

@ppb ppb deleted a comment from bors bot Jun 26, 2019
@nbraud
Copy link
Collaborator

nbraud commented Jun 26, 2019

bors r+

@astronouth7303 I'm about to go have lunch; I can deal with the release when I come back, if you don't get to it first.

bors bot added a commit that referenced this pull request Jun 26, 2019
175: Bump version to Release Candidate 1 r=nbraud a=astronouth7303

No major bugs have cropped up, just some optional lapses in functionality.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Jun 26, 2019

Build succeeded

  • macOS PYTHON:3.6.8
  • FreeBSD PYTHON:3.7
  • Linux python:3.6-slim
  • Windows python:3.6-windowsservercore-1809
  • docs
  • Windows python:3.7-windowsservercore-1809
  • macOS PYTHON:3.7.2
  • lint
  • Linux python:3.7-slim
  • FreeBSD PYTHON:3.6

@bors bors bot merged commit 8bfb79f into master Jun 26, 2019
@bors bors bot deleted the release-1.0rc1 branch June 26, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants