Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Failer to test_signal_once #549

Closed
pathunstrom opened this issue Oct 17, 2020 · 0 comments
Closed

Add a Failer to test_signal_once #549

pathunstrom opened this issue Oct 17, 2020 · 0 comments
Labels
Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB tests Related to tests. When applied to PRs is a note that tests are required before merge.

Comments

@pathunstrom
Copy link
Collaborator

pathunstrom commented Oct 17, 2020 •
edited
Loading

Relevant test: https://github.com/ppb/pursuedpybear/blob/canon/tests/test_engine.py#L60

We need to add a Failer with a reasonable timeout to this test to prevent infinite loops causing CI time outs.

Failer defaults to 1 second, which is reasonable for most tests that will fail with it.

Import ppb.testutils.Failer and add it to the basic_systems in the test in question.
@pathunstrom pathunstrom added new contributor Apply to issues we think can be tackled by people new to PPB tests Related to tests. When applied to PRs is a note that tests are required before merge. Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) labels Oct 17, 2020
@vicohart vicohart mentioned this issue May 17, 2021
Merged
bors bot added a commit that referenced this issue May 17, 2021
@bors @vicohart
Merge #617
15c6e61 
617: Issue 549 r=AstraLuma a=vicohart

Closing #549 
Added Failer to test_signal_once()

Co-authored-by: Victor Hart <vicohart@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB tests Related to tests. When applied to PRs is a note that tests are required before merge.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AstraLuma @pathunstrom