Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppb.events __all__ don't include all event types #648

Closed
pathunstrom opened this issue Oct 25, 2021 · 3 comments
Closed

ppb.events __all__ don't include all event types #648

pathunstrom opened this issue Oct 25, 2021 · 3 comments
Labels
Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB

Comments

@pathunstrom
Copy link
Collaborator

Mostly affects tooling, but we should include the missing events in the events __all__.

Noticed this in PyCharm when importing KeyPressed, looks like we're missing both Key events and the Mouse events, but should be a quick process of confirming which events are exported.
@pathunstrom pathunstrom added new contributor Apply to issues we think can be tackled by people new to PPB Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) labels Oct 25, 2021
@phileinsophos
Copy link

can I work on this

@AstraLuma
Copy link
Member

Yeah, go ahead

@pathunstrom
Copy link
Collaborator Author

Closed via #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AstraLuma @pathunstrom @phileinsophos