Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating __all__ events #649

Merged
merged 2 commits into from
Dec 24, 2021
Merged

updating __all__ events #649

merged 2 commits into from
Dec 24, 2021

Conversation

phileinsophos
Copy link

No description provided.

@phileinsophos phileinsophos requested a review from a team as a code owner October 28, 2021 15:46
@binny-the-binary-bear
Copy link

Thank you for contributing to PursuedPyBear! Don't forget to add yourself CONTRIBUTORS.md.

pathunstrom
pathunstrom reviewed Oct 28, 2021
View reviewed changes
ppb/events.py
'AssetLoaded',
'ButtonPressed',
'ButtonReleased',
'KeyPressed',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure to add KeyReleased to this as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@pathunstrom
Copy link
Collaborator

This looks good except for the one event I asked for, and add yourself to the contributors file.

pathunstrom
pathunstrom approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Thanks for the contribution!

bors bot added a commit that referenced this pull request Dec 16, 2021
@bors
Merge #649
24ebc0a 
649: updating __all__ events r=pathunstrom a=phileinSophos



Co-authored-by: omkar_patil <omkar_patil@dell.com>
@bors
Copy link
Contributor

bors bot commented Dec 16, 2021

Build failed:

@pathunstrom
Copy link
Collaborator

bors retry

bors bot added a commit that referenced this pull request Dec 24, 2021
@bors
Merge #649
d12b0a8 
649: updating __all__ events r=pathunstrom a=phileinSophos



Co-authored-by: omkar_patil <omkar_patil@dell.com>
@bors
Copy link
Contributor

bors bot commented Dec 24, 2021

Timed out.

@pathunstrom
Copy link
Collaborator

bors retry

@bors
Copy link
Contributor

bors bot commented Dec 24, 2021

Build succeeded:

@bors bors bot merged commit a409c84 into ppb:canon Dec 24, 2021
@pathunstrom pathunstrom mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phileinsophos @pathunstrom