Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation framework #230

Merged
merged 10 commits into from
Apr 21, 2019
Merged

Animation framework #230

merged 10 commits into from
Apr 21, 2019

Conversation

AstraLuma
Copy link
Member

Basically:

class MySprite(BaseSprite):
    image = Animate('MySprite_{0..10}.png', 5)

@AstraLuma AstraLuma requested a review from a team as a code owner April 6, 2019 01:19
@pathunstrom
Copy link
Collaborator

This leaves me wanting the file load API so we can move all the loading to the beginning.

But this looks promising. You want me to do the work in the renderer?

@AstraLuma
Copy link
Member Author

I just did.

@AstraLuma
Copy link
Member Author

AstraLuma commented Apr 6, 2019 •
edited
Loading

Ok, I think this is ready to use. I still have to:

  • Write tests
  • Write docs

@AstraLuma
Copy link
Member Author

Here's some test apps, making use of the Mutant Standard moon emoji
moon.zip

@AstraLuma AstraLuma mentioned this pull request Apr 6, 2019
Closed
@jamesBrosnahan
Copy link

Can the moon.zip file be added to examples?

@AstraLuma
Copy link
Member Author

@jamesBrosnahan not as it is, due to the license on Mutant Standard.

@AstraLuma AstraLuma changed the title [WIP] Animation framework Animation framework Apr 19, 2019
@AstraLuma
Copy link
Member Author

Ok, this is ready for review

@pathunstrom
Copy link
Collaborator

Tentative approval. I want to pull this and play with it a little way before giving the full green light. This shit is amazing, and the tests are clever.

@nbraud
Copy link
Contributor

nbraud commented Apr 19, 2019

@astronouth7303 Would it be OK for things in examples/ to depend on ppb-mutant for assets?
BTW, ppb-mutant doesn't currently specify a license.

pathunstrom
pathunstrom approved these changes Apr 21, 2019
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shit just works, and I love it.

@pathunstrom
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request Apr 21, 2019
@bors @AstraLuma
Merge #230
23e687b 
230: Animation framework r=pathunstrom a=astronouth7303

Basically:

```
class MySprite(BaseSprite):
    image = Animate('MySprite_{0..10}.png', 5)
```


Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Apr 21, 2019

Build succeeded

  • dockerfiles
  • docs
  • Linux Dockerfile:.ci/dockerfiles/python_3.6-slim
  • Linux Dockerfile:.ci/dockerfiles/python_3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows Dockerfile:.ci/dockerfiles/python_3.6-windowsservercore-1809
  • Windows Dockerfile:.ci/dockerfiles/python_3.7-windowsservercore-1809

@bors bors bot merged commit 0764bd5 into ppb:master Apr 21, 2019
@AstraLuma AstraLuma mentioned this pull request May 6, 2019
Closed
@AstraLuma AstraLuma deleted the feature-animation branch May 19, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AstraLuma @pathunstrom @jamesBrosnahan @nbraud