Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge #225" #247

Merged
merged 2 commits into from
May 5, 2019
Merged

Revert "Merge #225" #247

merged 2 commits into from
May 5, 2019

Conversation

AstraLuma
Copy link
Member

This rolls back the use of CI dockerfiles, so that cirrus brokenness no longer blocks other PRs.

This is not a rejection of #240.

@AstraLuma
Revert "Merge ppb#225"
c851039 
This reverts commit 8598c08, reversing
changes made to edd7499.
@AstraLuma AstraLuma requested a review from a team as a code owner May 4, 2019 19:10
@pathunstrom
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request May 5, 2019
@bors @AstraLuma
Merge #247
11f7286 
247: Revert "Merge #225" r=pathunstrom a=astronouth7303

This rolls back the use of CI dockerfiles, so that cirrus brokenness no longer blocks other PRs.

This is not a rejection of #240.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented May 5, 2019

Build succeeded

  • docs
  • Linux container:python:3.6-slim
  • Linux container:python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows container:python:3.6-windowsservercore-1809
  • Windows container:python:3.7-windowsservercore-1809

@bors bors bot merged commit 19e2ba2 into ppb:master May 5, 2019
@nbraud
Copy link
Contributor

nbraud commented May 5, 2019

Thanks for doing that <3

I need to revisit #240, but TBH I've been too frustrated with the quoting mess... :(

@AstraLuma AstraLuma deleted the undo-ci-docker branch May 19, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AstraLuma @pathunstrom @nbraud