Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement full numerical methods on the Sides API #272

Merged
merged 5 commits into from
May 19, 2019
Merged

Implement full numerical methods on the Sides API #272

merged 5 commits into from
May 19, 2019

Conversation

AstraLuma
Copy link
Member

Closes #193 by making Side objects pretend to be numbers.

@AstraLuma AstraLuma requested a review from a team as a code owner May 16, 2019 18:57
@pathunstrom
Copy link
Collaborator

bors r+

bors bot added a commit that referenced this pull request May 19, 2019
@bors @AstraLuma
Merge #272
204791c 
272: Implement full numerical methods on the Sides API r=pathunstrom a=astronouth7303

Closes #193 by making Side objects pretend to be numbers.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented May 19, 2019

Build succeeded

  • docs
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit ca71ffb into ppb:master May 19, 2019
@AstraLuma AstraLuma deleted the sides-float branch July 11, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add magic method to convert a side to an int.
2 participants
@AstraLuma @pathunstrom