-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound! 🔊 #326
Sound! 🔊 #326
Conversation
So, a quirk: pygame has a limited number of parallel sounds (channels) that can be played at once, defaulting to 8. My initial thought was to just allocate more channels if we run out, but then I realized that 1. Most naive implementations would spam this easily, 2. It's not obvious when to scale down. |
I figure we pick a number we think is reasonable and manageable and go with that. We can probably surface a parameter in the engine to modify it as well? |
Yeah, a parameter is easy enough. The pygame mixer surfaces so many parameters, though, and tbh I don't think game developers should have to think about that? |
I agree. We can pick the ones that are important and let advanced users subclass and modify as they like. |
Reorganized things so sound is broken up across several PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works wonderfully for basic use case.
bors r+ |
Build succeeded
|
Add a sound system!
Part of #327