Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write an ABC for assets #329

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Write an ABC for assets #329

merged 2 commits into from
Jul 23, 2019

Conversation

AstraLuma
Copy link
Member

Because of the confusion around assets, I figured I'd write an ABC about it.

@AstraLuma AstraLuma requested a review from a team as a code owner July 20, 2019 23:56
@pathunstrom
Copy link
Collaborator

Is this ready for review?

pathunstrom
pathunstrom approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can grok this.

bors r+

@pathunstrom pathunstrom added the bors Someone has bors r+ this PR label Jul 23, 2019
bors bot added a commit that referenced this pull request Jul 23, 2019
@bors @AstraLuma
Merge #329
53e99bf 
329: Write an ABC for assets r=pathunstrom a=astronouth7303

Because of the confusion around assets, I figured I'd write an ABC about it.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@bors
Copy link
Contributor

bors bot commented Jul 23, 2019

Build succeeded

  • docs
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • pep517
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit 89d896b into ppb:master Jul 23, 2019
@AstraLuma AstraLuma deleted the assets-abstract branch May 11, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
bors Someone has bors r+ this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AstraLuma @pathunstrom