Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Required Libaries for RHEL based distros #455

Merged
merged 1 commit into from
May 2, 2020
Merged

Add Required Libaries for RHEL based distros #455

merged 1 commit into from
May 2, 2020

Conversation

SanketDG
Copy link
Contributor

@SanketDG SanketDG commented May 2, 2020

No description provided.

@SanketDG SanketDG requested a review from a team as a code owner May 2, 2020 13:06
pathunstrom
pathunstrom requested changes May 2, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ignore that CI failure. Our intro bot failed.

This is very helpful, my only request is to add an entry to CONTRIBUTORS.md. The only field that's strictly required is name, and that can be a handle/pseudonym. With that done, I can merge this.

pathunstrom
pathunstrom approved these changes May 2, 2020
View reviewed changes
Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks so much!

bors r+

@pathunstrom pathunstrom added the bors Someone has bors r+ this PR label May 2, 2020
@bors
Copy link
Contributor

bors bot commented May 2, 2020

Build succeeded:

@bors bors bot merged commit b4569e4 into ppb:master May 2, 2020
@SanketDG SanketDG deleted the sanketdg/docs-add-libraries-for-fedora branch May 2, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom approved these changes

Assignees
No one assigned
Labels
bors Someone has bors r+ this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SanketDG @pathunstrom