Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrites the events docs. #459

Merged
merged 15 commits into from
May 9, 2020
Merged

Rewrites the events docs. #459

merged 15 commits into from
May 9, 2020

Conversation

pathunstrom
Copy link
Collaborator

No description provided.

@pathunstrom pathunstrom requested a review from a team as a code owner May 8, 2020 02:15
AstraLuma
AstraLuma requested changes May 8, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also got:

pickling environment... WARNING: duplicate object description of ppb.events.PlaySound, other instance in reference/sound, use :noindex: for one of them

ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Show resolved Hide resolved
ppb/events.py Show resolved Hide resolved
docs/reference/events.rst Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
pathunstrom and others added 12 commits May 7, 2020 23:04
@pathunstrom @AstraLuma
Update ppb/events.py
203f974 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
59ff1bf 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
40518be 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
aaee227 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
3c4f94c 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
9a0cc3d 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
646cc98 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
c71e0b2 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Update ppb/events.py
bfeb099 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom @AstraLuma
Apply suggestions from code review
08ebb72 
Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
@pathunstrom
Addresses code review feedback.
f67af2e
@pathunstrom
minor touchup.
abc14cb
AstraLuma
AstraLuma requested changes May 9, 2020
View reviewed changes
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Outdated Show resolved Hide resolved
ppb/events.py Show resolved Hide resolved
AstraLuma
AstraLuma requested changes May 9, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[edit: nevermind, none of this applied to this PR]

AstraLuma
AstraLuma approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

bors r+

@bors
Copy link
Contributor

bors bot commented May 9, 2020

Build succeeded:

@bors bors bot merged commit 8577746 into ppb:master May 9, 2020
@pathunstrom pathunstrom mentioned this pull request May 12, 2020
Closed
4 tasks
@pathunstrom pathunstrom deleted the rewrite-events-docs branch May 15, 2020 23:54
@pathunstrom pathunstrom restored the rewrite-events-docs branch July 15, 2020 22:47
@pathunstrom pathunstrom deleted the rewrite-events-docs branch October 24, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pathunstrom @AstraLuma