Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed pos to position on Ship class. #611

Merged
merged 2 commits into from
May 16, 2021
Merged

changed pos to position on Ship class. #611

merged 2 commits into from
May 16, 2021

Conversation

doobeh
Copy link
Contributor

@doobeh doobeh commented May 16, 2021

Ship(pos=(...)) doesn't adjust the location. Changing to position to fix. Doesn't cause an error, but might lead new users to think pos is a keyword to set position.

`pos` doesn't do anything
@doobeh doobeh requested a review from a team as a code owner May 16, 2021 17:48
@binny-the-binary-bear
Copy link

Thank you for contributing to PursuedPyBear! Don't forget to add yourself CONTRIBUTORS.md.

Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just add yourself to the contributors list.

@doobeh
Copy link
Contributor Author

doobeh commented May 16, 2021

Added-- thanks!

@AstraLuma
Copy link
Member

bors r+

@bors bors bot merged commit f7100ad into ppb:canon May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants