-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a issue in viztest/main.py #638
Conversation
Thank you for contributing to PursuedPyBear! Don't forget to add yourself |
Primary feedback is we don't want to track the .replit file. Feel free to include it in the project .gitignore, and add your information to the CONTRIBUTORS file. If you'd like to go above and beyond, you could rename the file from main.py to triangles.py or similar. (Also, don't worry about that test failure, not your fault.) |
Thanks for the reply , this was my first commit ever . I'll try to improve .
|
As instructed by you , I've change the file name to "triangles.py " and also added my information in CONTRIBUTORS.md . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
bors r+
Would you like to get a shoutout on Twitter from the pursuedpybear account? |
|
Changed name from 'equilateral_tri' to 'square_tri' !