Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a issue in viztest/main.py #638

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Fixed a issue in viztest/main.py #638

merged 2 commits into from
Oct 1, 2021

Conversation

abhijeetgupto
Copy link

Changed name from 'equilateral_tri' to 'square_tri' !

@abhijeetgupto abhijeetgupto requested a review from a team as a code owner October 1, 2021 18:22
@binny-the-binary-bear
Copy link

Thank you for contributing to PursuedPyBear! Don't forget to add yourself CONTRIBUTORS.md.

@pathunstrom
Copy link
Collaborator

pathunstrom commented Oct 1, 2021

Primary feedback is we don't want to track the .replit file. Feel free to include it in the project .gitignore, and add your information to the CONTRIBUTORS file.

If you'd like to go above and beyond, you could rename the file from main.py to triangles.py or similar.

(Also, don't worry about that test failure, not your fault.)

@abhijeetgupto
Copy link
Author

Thanks for the reply , this was my first commit ever . I'll try to improve .
Thanks!

Primary feedback is we don't want to track the .replit file. Feel free to include it in the project .gitignore, and add your information to the CONTRIBUTORS file.

If you'd like to go above and beyond, you could rename the file from main.py to triangles.py or similar.

(Also, don't worry about that test failure, not your fault.)

@abhijeetgupto
Copy link
Author

As instructed by you , I've change the file name to "triangles.py " and also added my information in CONTRIBUTORS.md .

Copy link
Collaborator

@pathunstrom pathunstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

bors r+

@pathunstrom
Copy link
Collaborator

Would you like to get a shoutout on Twitter from the pursuedpybear account?

@abhijeetgupto
Copy link
Author

Would you like to get a shoutout on Twitter from the pursuedpybear account?
Of course !
Thanks , I really appreciate that .

@bors bors bot merged commit 09db672 into ppb:canon Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants