Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added python3.10 to CI #646

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Added python3.10 to CI #646

merged 1 commit into from
Oct 18, 2021

Conversation

sgavil
Copy link

@sgavil sgavil commented Oct 11, 2021 •
edited by AstraLuma
Loading

Fixes #643

@sgavil sgavil requested a review from a team as a code owner October 11, 2021 11:24
@sgavil sgavil force-pushed the python3.10-ci branch 2 times, most recently from 448c3af to 39ee7b2 Compare October 13, 2021 17:47
@sgavil sgavil changed the title Added python3.10 to CI [Draft] Added python3.10 to CI Oct 13, 2021
AstraLuma
AstraLuma requested changes Oct 14, 2021
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the very exciting CI failures, can you say 3.10 instead of 3.10.0 everywhere, so that CI automatically upgrades when 3.10.1 happens. (Except mac, because pyenv is unhelpful in this regard.)

@sgavil sgavil force-pushed the python3.10-ci branch 3 times, most recently from eaeb34f to 3b4e3f7 Compare October 16, 2021 10:05
@sgavil sgavil changed the title [Draft] Added python3.10 to CI Added python3.10 to CI Oct 16, 2021
@sgavil sgavil requested a review from AstraLuma October 16, 2021 10:59
@sgavil
Copy link
Author

sgavil commented Oct 18, 2021

@AstraLuma Done!

AstraLuma
AstraLuma approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised mac worked (given my past experience of mac on cirrus)

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 18, 2021

Build succeeded:

@bors bors bot merged commit 9da7aa7 into ppb:canon Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python 3.10
2 participants
@sgavil @AstraLuma