Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the examples zip job #656

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Fix the examples zip job #656

merged 1 commit into from
Dec 30, 2021

Conversation

pathunstrom
Copy link
Collaborator

we were saving into working_directory/examples.zip and uploading temporary_directory/examples.zip This builds and uploads from the temp directory.

@pathunstrom pathunstrom requested a review from a team as a code owner December 30, 2021 02:19
AstraLuma
AstraLuma approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly, as long as it's consistent

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build succeeded:

@bors bors bot merged commit d857c46 into ppb:canon Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AstraLuma AstraLuma AstraLuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pathunstrom @AstraLuma