Remove allocations during bass device sync polling operation #6124
Conversation
peppy
force-pushed
the
bass-sync-device-allocs
branch
from
e8bce92
to
e51e7f9
Compare
peppy
force-pushed
the
bass-sync-device-allocs
branch
from
e51e7f9
to
7ce8d47
Compare
| // Can't use `MoveToImmutable` here as we don't provide accurate capacity. | ||
| return new KeyCombination(keys.ToImmutableList()); |
There was a problem hiding this comment.
Not sure what this change is doing in here...
There was a problem hiding this comment.
Also fixed a couple of incorrect calls on array building. Check underlying implementation for reasoning (one allocates, other doesn't).
See 7ce8d47.
I can move to another PR if you want, but it was one line change.
There was a problem hiding this comment.
In this particular case it looks to me that the difference should be zero and both will allocate, but /shrug. (The .MoveToImmutable() stuff seems valid.)
There was a problem hiding this comment.
Oh yeah, I meant to revert this case. As per the comment, we can't use MoveTo due to capacity not being set (a hidden gotcha).
This will still allocate as the call I incorrectly "reverted" to is synonymous with the original.
| @@ -341,7 +341,7 @@ private static IEnumerable<Display> getSDLDisplays() | |||
| Logger.Log($"Failed to retrieve SDL display at index ({i})", level: LogLevel.Error); | |||
| } | |||
|
|
|||
| return builder.ToImmutable(); | |||
| return builder.MoveToImmutable(); | |||
There was a problem hiding this comment.
...or this one either, for that matter...
Minor gains because this is just a one second poll, but is what it is.
Also fixed a couple of incorrect calls on array building. Check underlying implementation for reasoning (one allocates, other doesn't).