Add room database retrieval and validation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
changed the title
…player-database-retrieval
…player-database-retrieval
smoogipoo
reviewed
Dec 16, 2020
smoogipoo
approved these changes
Dec 16, 2020
smoogipoo
requested changes
Dec 16, 2020
peppy
added a commit
to peppy/osu-server-spectator
that referenced
this pull request
Dec 16, 2020
We didn't have any CI until now, so this is the bare minimum. Using the windows build agent as it has been updated to net5.0 (unlike linux, which is [currently in rollout](actions/runner-images#1891 (comment))). Note that ppy#4 should be merged first to fix a compilation error.
smoogipoo
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this currently breaks the sample client project (or, rather, it requires a database for it to function correctly). I'm figuring out the best way to fix this, so while this PR is usable for testing against an actual database backing, don't merge just yet.