Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark score not ranked if not passed #11141

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Apr 3, 2024

Related to ppy/osu#26369

@peppy peppy merged commit 9d9ec97 into ppy:master Apr 3, 2024
3 checks passed
@peppy
Copy link
Sponsor Member

peppy commented Apr 3, 2024

I'll run a fixup on all existing scores after rolling this out.

@nanaya
Copy link
Collaborator Author

nanaya commented Apr 3, 2024

I thought the initial value here is just temporary and there's another process which updates it using a more detailed check?

@bdach
Copy link
Contributor

bdach commented Apr 3, 2024

I thought the initial value here is just temporary and there's another process which updates it using a more detailed check?

If you're talking about osu-queue-score-statistics then it doesn't really touch this flag right now. The only intended use case where it'd change value from what this change gives it would be beatmaps getting ranked, or scores getting nuked due to a restrict or something. Which... I'm not sure either of those is actually implemented right now?

osu-queue-score-statistics will touch preserve once we're done with ppy/osu-queue-score-statistics#141.

I attempted to document this better in https://github.com/ppy/osu-infrastructure/blob/master/score-submission.md#-decide-on-storage-method-and-structure, but given the ongoing perpetual confusion I'm not sure that did much...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants