Filter out restricted user from Playlist scores #11488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
changed the title
nanaya
requested changes
Sep 13, 2024
app/Http/Controllers/Multiplayer/Rooms/Playlist/ScoresController.php
Outdated
Show resolved
Hide resolved
nanaya
requested changes
Sep 13, 2024
| @@ -130,4 +131,9 @@ public function updateWithScoreLink(ScoreLink $scoreLink): bool | |||
| 'total_score' => $score->total_score, | |||
| ])->save(); | |||
| } | |||
|
|
|||
| public function user(): BelongsTo | |||
There was a problem hiding this comment.
oh right, this should be in relation function area?
There was a problem hiding this comment.
are we still doing that 🤔
There was a problem hiding this comment.
I think so for scopes, relations and laravel model setters/getters? 🤔
…er.php Co-authored-by: Edho Arief <me@nanaya.net>
nanaya
approved these changes
Sep 13, 2024
bdach
added a commit
to bdach/osu-server-spectator
that referenced
this pull request
Sep 17, 2024
This is a port of ppy/osu-web#11488 for spectator server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.