Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show team flag on user display #11721

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Show team flag on user display #11721

merged 4 commits into from
Dec 11, 2024

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Dec 6, 2024 •
edited
Loading

I think this covers everything? 🤔

@nanaya nanaya force-pushed the team-profile-page branch from 86a89e8 to 59e4e43 Compare December 6, 2024 13:45
@nanaya nanaya mentioned this pull request Dec 9, 2024
Merged
1 task
@nanaya nanaya force-pushed the team-profile-page branch 11 times, most recently from d0c5b2f to 8851fa5 Compare December 10, 2024 12:27
@nanaya nanaya marked this pull request as ready for review December 10, 2024 12:43
@nanaya
Copy link
Collaborator Author

nanaya commented Dec 10, 2024

I guess this is fine for now instead of scope creeping everything.

notbakaneko
notbakaneko requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
null flags might need a placeholder or something...

notbakaneko
notbakaneko approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the default colour of null flags isn't very visible in the listing where it'll show up, and could do with a ? marker or something like unknown country flags but we'll see how it goes 🤷

@notbakaneko notbakaneko merged commit b3b0ac3 into ppy:master Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notbakaneko notbakaneko notbakaneko approved these changes

Assignees
No one assigned
Labels
area:user-profile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nanaya @notbakaneko