Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taiko inner and outer drums fade in/fade out doesn't match osu! stable #8888

Closed
mouzedrift opened this issue Apr 28, 2020 · 6 comments
Closed

Comments

@mouzedrift
Copy link
Contributor

Screenshots or videos showing encountered issue:
https://youtu.be/ctbLHabnKFY

osu!lazer version:
commit 0ffd9da

@peppy
Copy link
Sponsor Member

peppy commented Apr 30, 2020

Is this actually annoying/important enough to split the legacy/default implementations up? From the video is is a near imperceivable difference.

@peppy
Copy link
Sponsor Member

peppy commented Jun 3, 2020

Going to close for now as "no". Please comment if you disagree.

@peppy peppy closed this as completed Jun 3, 2020
@mouzedrift
Copy link
Contributor Author

wondering if this could be adjusted since other visual differences (such as #25983) are now being addressed as well. i never really noticed the reply in 2020 so that's probably why i never replied but i came across this again.

@peppy
Copy link
Sponsor Member

peppy commented Jan 17, 2024

Dunno, maybe give it a try yourself.

@mouzedrift
Copy link
Contributor Author

i wouldn't mind trying but i would probably need some code as reference from stable to see what exactly is different

@peppy
Copy link
Sponsor Member

peppy commented Jan 17, 2024

                if (InputManager.rightButton1i)
                {
                    taikoOuterLeft.Transformations.Clear();
                    taikoOuterLeft.Transformations.Add(new Transformation(TransformationType.Fade,
                                                                          taikoOuterLeft.Alpha, 1,
                                                                          GameBase.Time,
                                                                          GameBase.Time +
                                                                          (int)
                                                                          ((1 - taikoOuterLeft.Alpha) * 80),
                                                                          EasingTypes.Out));
                    taikoOuterLeft.Transformations.Add(new Transformation(TransformationType.Fade, 1, 0,
                                                                          GameBase.Time + 100, GameBase.Time + 150));
                }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants