Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix taiko legacy input drum animation fade not matching osu!stable #26608

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

mouzedrift
Copy link
Contributor

Adds the missing delay before fading out the drum and changes the easing to Easing.Out which should match stable's behavior for legacy skins. The stable code was provided in #8888

Comparing osu!lazer (top) vs osu!stable (bottom)

comparison.mp4

@peppy peppy self-requested a review January 18, 2024 06:48
@bdach bdach merged commit 1cde18b into ppy:master Jan 22, 2024
15 of 17 checks passed
@mouzedrift mouzedrift deleted the taiko-drum-fade-fix branch January 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants