-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove combo scaling from Aim and Speed from osu! performance calculation #16280
Merged
+49
−21
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
cff9dab
Remove combo scaling and change miss penalty
apollo-dw 86ad42a
Nerf length bonus
apollo-dw 489aa43
Make miss penalty harsher
apollo-dw bac4cfe
Use frost's miss count penalty
apollo-dw 60e2a8e
Use MathNet for miss penalty calculation, and use old penalty formula…
apollo-dw 5640918
New miss penalty formula, using relevant difficult notes in each skil…
apollo-dw e9589e5
Fix logical error
apollo-dw d514567
Merge master
apollo-dw 8ce6e3c
Remove mathnet
apollo-dw 4f257d6
Clean up unsuccessful merge
apollo-dw fd1028f
Use clockrate in the difficult strain count method
apollo-dw d2b815b
Add miss penalty comment
apollo-dw 75be4e8
Remove abusable 0.66 threshold by averaging
Luminiscental 1320790
Remove unnecessary truncation
Luminiscental 391110c
Remove abusable 0.66 threshold by averaging
apollo-dw 443640a
Revert "Remove abusable 0.66 threshold by averaging"
apollo-dw f07bfcd
Merge pull request #6 from apollo-dw/revert-5-no-combo-scaling
apollo-dw dcb9693
Weight difficult strain count against the top strain
apollo-dw b3e90c3
Merge
apollo-dw 400abc1
Add attribute ids to mapping functions
smoogipoo 5989467
Reword comment and rename argument
apollo-dw 1ae8ff0
Merge branch 'master' into no-combo-scaling
apollo-dw da31ca1
Use note strains instead of sectional strains
apollo-dw 94a46ab
Rescale miss penalty for note strains
apollo-dw c18df86
Remove clockrate factor
apollo-dw 580e43b
Merge branch 'master' into no-combo-scaling
apollo-dw 0d4fe96
Merge branch 'master' into no-combo-scaling
apollo-dw 2f335a7
Switch to using osuAttributes
apollo-dw 23d0c03
Merge branch 'master' into no-combo-scaling
apollo-dw 7d34542
use difficulty instead of topstrain
TextAdventurer12 0db910d
cap each note at adding 1 difficult strain count
TextAdventurer12 9f5f6b5
stop capping difficult strains per note
TextAdventurer12 b32d73e
adjust weighting function
TextAdventurer12 e2a5d19
adjust count difficult strains formula
TextAdventurer12 1d19bd2
Merge pull request #7 from TextAdventurer12/no-combo-scaling
apollo-dw 9b60abe
Merge branch 'ppy:master' into no-combo-scaling
apollo-dw c1efcc0
Change miss penalty (nerf longer maps)
TextAdventurer12 9ff277c
Merge pull request #9 from TextAdventurer12/no-combo-scaling
apollo-dw 20c54ab
Apply code quality changes
apollo-dw 61afda1
Fix NaN case when difficulty is 0
apollo-dw c25e1bd
Use correct operation for 0 difficulty case
apollo-dw a7e1d35
Update osu.Game/Rulesets/Difficulty/DifficultyAttributes.cs
apollo-dw f54a5a5
Merge branch 'master' into no-combo-scaling
tsunyoku f30ac5d
Merge branch 'master' into no-combo-scaling
bdach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point I'd really like to rid of the indexing of skills because it makes me anxious but future problem..