-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow aspect ratios smaller than the default in taiko #21883
Conversation
As far as I'm aware, standardising to 16:9 when classic mod isn't active was intentional. See #13047 for paper trail. I don't really understand the insistence on allowing people to submit scores with different aspect ratios to one leaderboard and creating an uneven playing field. |
Yes exactly, because of exploits stemming from aspect ratios wider than 16:9, ratios smaller than 16:9 do not give an advantage, only a disadvantage, but some players prefer playing this way. This is why this pr only allows smaller aspect ratios. |
I see people claiming the contrary?
|
Though the same effect can be achieved by simply making the game bigger and/or covering the screen, an effect not possible to recreate for aspect ratios wider than 16:9, as also mentioned in that discussion. |
Yeah I don't feel like this PR can proceed without a wider survey of the community opinion. To me it feels unnatural to let players affect game balance by messing with their screen size even if it's only to their detriment. Other suggestions like having the aspect ratio denoted as a system mod on the score were also proposed in the discussion thread. This PR is jumping the gun IMO. |
The problem is that there is no other solution. There's a great amount of players who have always played the game this way, who would be forced onto a completely different experience. And as these players would still like to compete in the actual game leaderboards, something like a mod to split them up wouldn't be to anyones liking either. If we don't want to lose these players, the only thing up to debate would be something potentially just visually showing that the score was made in a different aspect ratio, but anything else wouldn't be appreciated. This PR would still be the correct first step. I could set up a few polls in community taiko servers to confirm this. |
This sort of survey should take place transparently, on official channels, rather than by backchanneling in community servers. |
@sw1tchbl4d3r could you please provide a comparison video or screenshots for this, showing how it compares before/after? |
Screenshots and videos from #17225 apply, we merely remove the dependency on the classic mod as long as the aspect ratio is smaller than 16:9, so the 4:3 and 16:9 examples should suffice. |
In an interest of getting things in a playable state for the majority, I'm going to get this in. It's easier to push this change out (to more closely match stable) and then wait for people to potentially complain about the change. If there's any resistance to this change from players then we can reconsider. I understand that some will disagree with this change, but at this point our goal is to get people more willing to move over, and do so without being required to always apply the "classic" mod to get the game in a playable state. |
With the release of the lazer subserver there's been an influx of people trying it out, and one of the biggest concerns for taiko players is that the 4:3 aspect ratio isn't supported in lazer without the classic mod.
This was most likely done to prevent aspect ratio exploits, as in ultra wide resolutions, to see more notes or see them for longer.
To prevent exploits but still please 4:3 players, this PR allows aspect ratios below 16:9, and only locks wider aspect ratios.