Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extreme aspect ratios in taiko #23325

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

sw1tchbl4d3r
Copy link
Contributor

@sw1tchbl4d3r sw1tchbl4d3r commented Apr 27, 2023

This PR fixes two weird behaviors at extreme aspect ratios.
It incorporates some of the fixes mentioned in #22581.

  1. The ratio for the scroll speed calculation now depends on width rather than height. This ensures that on wide aspect ratios the notes become faster to avoid showing more notes. Height ratio didn't always correspond to width ratio.
  2. A lower bound for the aspect ratio has been added, that being 5:4, to ensure extreme values don't break the playfield
  3. The height of the playfield is now limited to 1/3 of the screen, as per Adjust taiko (again) to limit minimum aspect ratio to 5:4 #22581 (comment)

There are some things that could still be done, like avoiding that the playfield moves up on small ratios, and maybe even fixing the wide aspect ratio issue in a graphical way instead of speeding up the notes, but this is a good start.

Master:

oldcap.mp4

This PR:

newcap.mp4

Closes #22581
Closes #22853

@peppy peppy self-requested a review April 27, 2023 10:34
Copy link
Sponsor Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better than what I had. Won't merge for a while to let anyone else interested check for issues.

@sw1tchbl4d3r
Copy link
Contributor Author

As a reference, the way stable dealt with wide aspect ratios is described in #19604, which hasn't seen much activity recently, but creates a "fade-in" for notes beyond a certain threshold while keeping the scroll speed identical. Something similar to this applied to not just classic could be a further step.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, as far as I can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen scaling breaks judgement sizing in taiko
3 participants