Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a realm subscription to avoid overhead when hovering a toolbar button #26086

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Use a realm subscription to avoid overhead when hovering a toolbar button #26086

merged 2 commits into from
Dec 23, 2023

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Dec 23, 2023

Addresses #26018.

@bdach bdach added type:performance realm deals with local realm database area:toolbar labels Dec 23, 2023
@bdach bdach self-requested a review December 23, 2023 18:27
@bdach
Copy link
Collaborator

bdach commented Dec 23, 2023

Fixed unrelated issue while I was there (68430d6), seems fine otherwise.

@peppy peppy merged commit ee00f7e into ppy:master Dec 23, 2023
11 checks passed
@peppy peppy deleted the fix-toolbar-button-lag branch January 4, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdach bdach bdach approved these changes

Assignees
No one assigned
Labels
area:toolbar realm deals with local realm database size/S type:performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppy @bdach