Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust menu buttons #26201

Merged
merged 6 commits into from
Dec 31, 2023
Merged

Adjust menu buttons #26201

merged 6 commits into from
Dec 31, 2023

Conversation

iminlikewithyou
Copy link
Contributor

this pull request slightly updates the sizes and positions of the main menu buttons' children to improve the visual balance of the buttons.

current:
image

updated:
image

as a consequence of the very slight size increase, the rotation of the bounce was tweaked a bit lower.

6eTgkg9Tcap4
YqEzbAGhvSsH

@cl8n
Copy link
Member

cl8n commented Dec 28, 2023

I think the slanted alignment looks kind of awkward in isolation, despite matching the shape of the button itself better. the size bump on the icons seems nice though.

@iminlikewithyou
Copy link
Contributor Author

it could be better to move both the icon and the text to the left - so that the icon remains directly above the center of the text, and see if that works

but i definitely think that in the current design, it's extremely obvious that the icon and text seems extremely right-shifted

@peppy
Copy link
Sponsor Member

peppy commented Dec 31, 2023

This menu is going away soon, but seems fine to adjust it to read better for now.

@peppy peppy merged commit e107338 into ppy:master Dec 31, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants