Fix global audio offset suggestion feature not taking previous offset value into account #26222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value into account See https://osu.ppy.sh/comments/2989193 etc.
peppy
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://osu.ppy.sh/comments/2989193 etc.
Gonna be honest I'm only like 40% confident this is right. But it seems to be similar enough to what the beatmap offset slider is doing so I'm hoping that I copied correctly.
Notably the beatmap offset is intentionally not factored in here - as I understand it, its intention is to fix singular beatmaps in relation to most other beatmaps, and as such I assume that factoring in beatmap offset to the global offset suggestion is incorrect.