Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keybinds for 'Grid from points' and cycling grid type #26303

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Add keybinds for 'Grid from points' and cycling grid type #26303

wants to merge 44 commits into from

Conversation

OliBomby
Copy link
Contributor

@OliBomby OliBomby commented Jan 1, 2024 •
edited
Loading

Requires:

Using the tool boxes on the right frequently is quite annoying, so I also added keybinds for cycling the grid type (H) and activating the 'Grid from points' feature (B).

2023-12-31.21-07-56.mp4

@OliBomby
Add rotation to snap grid visual
6219cd0
@OliBomby
add rotation to snapped position
52b119c
@OliBomby
fix typo
0ae3162
@OliBomby
Added Triangular snap grid
19468a0
@OliBomby
clean up code duplication
2acd8f4
@OliBomby
fix wrong grid cache being used
fa64b9b
@OliBomby
add basic control by grid tool box
4dc3edf
@OliBomby
Add comment
b969831
@OliBomby
improve code
34dfab7
@OliBomby
Fix snapping going out of bounds
7d4af67
@OliBomby
clarify comment
2033d20
@OliBomby
Add option to change grid type
87b1523
@OliBomby
Make it actually possible to change grid type
a8aa10e
@OliBomby
reduce opacity of middle cardinal lines
4e5cb98
@OliBomby
Add circular grid
c6ebd5e
@OliBomby
Added bindables and binding with BindTo
9c5759a
@OliBomby
fix compile
0f9bdbc
@OliBomby
flip along grid axis
44007d5
@OliBomby
Rotate popover rotates around grid center
3306858
@OliBomby
Saving exact grid spacing
9dc0721
@OliBomby
kinda working grid from points
f6df836
@OliBomby
improve the grid from points
4db10b3
@OliBomby
fix period
ea885e8
@OliBomby
deselect stuff stuff when grid from points
596ce9e
@OliBomby
add right click for abort
9a514f3
@OliBomby
use G to change grid type
43d0511
@OliBomby
improve UI
e429fc2
@OliBomby
Change maximum dist from grid from points to 64
6fcabd1
@OliBomby
add hotkey for grid from points
59e232f
@OliBomby
move OutlineTriangle code down
0a6295f
@bdach
Copy link
Collaborator

bdach commented Jan 1, 2024

1.3k line diffstat moves this even lower on review priority list than it already was.

Did everything here need to be in a single pull?

@OliBomby
Copy link
Contributor Author

OliBomby commented Jan 1, 2024

Right I forgot to split it up to make review more palatable.

This was referenced Jan 1, 2024
Merged
Merged
Merged
Open
@OliBomby
Fix grid type cycling not taking into account the radio button selection
4de9cf5
@OliBomby
Remove Masking from PositionSnapGrid
24e9e28 
This caused issues in rendering the outline of the grid because the outline was getting masked at some resolutions.
@OliBomby
Fix masking in circular snap grid
ded11e0
bdach added a commit to bdach/osu that referenced this pull request Jun 20, 2024
@bdach
Reimplement stable polygon tool
225b309 
Addresses ppy#19970.

While yes, ppy#26303 is also a thing,
in discussing with users I don't think that grids are going to be able
to deprecate this feature.

Logic transcribed verbatim from stable.
@bdach bdach mentioned this pull request Jun 20, 2024
Merged
@OliBomby OliBomby changed the title Add customization to positional snap grids in the editor Add keybinds for 'Grid from points' and cycling grid type Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OliBomby @bdach