Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bindable overheads of health displays #26455

Merged
merged 15 commits into from
Jan 11, 2024

Conversation

peppy
Copy link
Sponsor Member

@peppy peppy commented Jan 9, 2024

master:

CleanShot 2024-01-09 at 08 13 18

peppy@d83b8db

CleanShot 2024-01-09 at 08 12 02

peppy@12a59eb

CleanShot 2024-01-09 at 08 29 50

Remaining alloc overheads are from SmoothPath alone. Heath displays are for the most part allocation free now.

@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Jan 9, 2024
@peppy
Copy link
Sponsor Member Author

peppy commented Jan 10, 2024

I added one more commit to attempt to reduce Color4 allocations but turns out it didn't help (all the overhead is inside Interpolation). Probably fine to leave though.

Before After
2024-01-11 00 36 05@2x 2024-01-11 00 35 04@2x

@bdach bdach enabled auto-merge January 11, 2024 09:33
@bdach bdach merged commit da29faf into ppy:master Jan 11, 2024
10 of 11 checks passed
@peppy peppy deleted the health-less-value-changed branch January 12, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/L type:performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants