-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further reduce allocation overhead in ScrollingHitObjectContainer
#26863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to use a ReadOnlyDictionary<>
since I don't feel too good about exposing as a Dictionary<>
. It may also reduce some allocations due to linq queries in the other places I've adjusted.
[rant] I've proposed ppy/osu-framework#6163 framework-side that could be used here. |
Part 2 of #26788
Not sure how safe is making dictionary
public
though. Would've made it protected, however some mods (such as Depth) will benefit from using that instead ofAliveObjects
.