-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display which mods grant pp #26934
Display which mods grant pp #26934
Conversation
|
I'm not sure what other naming to use for this. |
something like "awards pp" or "pp enabled" would be more clear but I admit it reads a little clunky compared to current. I'm not sure either... |
I was going to mention this, but we might actually change these scores to not show on the leaderboard, just to keep things simple. I think the language is fine for now from this angle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine as a first step 👍
In mod select and in song select footer.
2024-02-01.22-41-47.mp4
I'll quote the disclaimer from the issue again:
This doesn't work 100% correctly in multiplayer, namely when a user is selecting from free mods, but that is a pre-existing issue that affects the mod multiplier and the beatmap attribute display too so I'd ask to look away for the time being.
Please give f89923a particular attention when reviewing. And yes for now that commit is written very conservatively to match the server-side implementation (which the
Ranked
property will be replacing).