Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiplayer/playlists lounge screen disposing rooms synchronously #27021

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

frenzibyte
Copy link
Member

This starts to become noticeable as players began to create more rooms and playlists in osu!lazer. When changing the ruleset, RoomManager removes the previously existing rooms, signaling RoomsContainer to remove and dispose all existing rooms synchronously. This gets bad very quickly when the number of rooms exceeds about 10.

Before:

CleanShot.2024-02-04.at.17.13.44.mp4

After:

CleanShot.2024-02-04.at.17.15.17.mp4

(the delay between the loading layer hiding and the rooms actually appearing is an issue that occurs on master as well. not entirely sure what's going on there.)

@bdach
Copy link
Collaborator

bdach commented Feb 5, 2024

Screen needs pooling and more DLUW at some point, but for now this'll do.

@bdach bdach merged commit 462a1c5 into ppy:master Feb 5, 2024
13 of 17 checks passed
@frenzibyte frenzibyte deleted the fix-rooms-container-performance branch February 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching rulesets on the multiplayer screen sometimes causes a huge lag spike
2 participants