Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ModClassic ranked in default configuration #27149

Closed
wants to merge 1 commit into from

Conversation

stanriders
Copy link
Member

Related to #25350

Rationale is that in default configuration (Osu)ModClassic has all settings enabled which should equal to osu!stable gameplay. Taiko CL doesn't have any settings so there's no problem with enabling it as well.

Ideally all settings should be ranked and dealt in diff/pp calc accordingly, but I think this is a good first step

@Detze
Copy link
Contributor

Detze commented Feb 12, 2024

#11311 should probably be resolved before this. For the example of osu! Great hit window with OD 10, legacy scores (scores from stable marked with the Classic mod) used a 19.5 ms hit window, while current lazer Classic scores use a 20 ms hit window. This changes the correct pp values; the pp calculation should be aware of which hit window was used. Moreover, resolving the issue could also introduce a difference in Classic hit windows between lazer versions before and after the resolution. (for example, if #26452 was merged, there would be an option to use either the 19.5 ms or the 20 ms window).

There are also gameplay differences between lazer and stable that could feasibly be re-added to Classic mod in the future, examples include legacy osu!mania note lock (mentioned here), or osu!mania no long note accuracy (analogously to the osu! Classic option).

@cdwcgt
Copy link
Contributor

cdwcgt commented Feb 12, 2024

also #11769 which mention in ppy/osu-queue-score-statistics#180
not sure the list of different between classic lazer and stable, maybe exists somewhere?

@stanriders
Copy link
Member Author

Ah I see. I wish that was mentioned somewhere in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants