Reduce osu editor allocations with many objects selected #27249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EVAST9919
commented
Feb 19, 2024
EVAST9919
commented
| master | pr |
|---|---|
EVAST9919
commented
Feb 19, 2024
| @@ -92,6 +89,10 @@ public override void UpdateFrom(HitCircle hitObject) | |||
|
|
|||
| ring.Scale = new Vector2(1 + 0.1f * ringScale); | |||
| content.Alpha = 0.9f * (1 - alpha); | |||
|
|
|||
| // TODO: should only update colour on skin/combo/object change. | |||
There was a problem hiding this comment.
This is a quick band-aid fix. We are still performing skin lookup on each frame, but now only for visible markers (previously for every alive one). Reworking this will require a bit of refactoring, which should probably be in it's own pr.
peppy
approved these changes
Feb 20, 2024
peppy
added a commit
to peppy/osu
that referenced
this pull request
Feb 26, 2024
Regressed with ppy#27249. I was suspicious of this specific operation at the time but didn't test properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.