Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Catch NF penalty to match Osu #28353

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Changed Catch NF penalty to match Osu #28353

merged 1 commit into from
Jun 15, 2024
+1 −1

Conversation

Givikap120
Copy link
Contributor

No description provided.

@smoogipoo smoogipoo requested a review from a team May 29, 2024 18:07
@smoogipoo
Copy link
Contributor

!diffcalc
RULESET=catch

@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited
Loading

Target: #28353
Spreadsheet: https://docs.google.com/spreadsheets/d/1VPrj6ljCfNNy1XZyOEOwNV4UOYlHsezXKwPiHWgjS8I/edit

@peppy
Copy link
Sponsor Member

peppy commented Jun 13, 2024

For these kinds of changes are we waiting from pp committee approval?

@smoogipoo
Copy link
Contributor

Yes, I always look for committee approval before diving into any SR/PP change. It's less effort that way.

Flawnpiece
Flawnpiece approved these changes Jun 13, 2024
View reviewed changes
Copy link

@Flawnpiece Flawnpiece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the NF penalty to match with std is something that would be welcomed in catch. There isn't really any downside to this change (don't think we will see any rise of abuse, and even so it will be very minimal).

Sorceress4628
Sorceress4628 approved these changes Jun 14, 2024
View reviewed changes
Copy link

@Sorceress4628 Sorceress4628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a change most of the catch community is in favour of, we like this

@smoogipoo smoogipoo merged commit 2ecb9cd into ppy:master Jun 15, 2024
8 of 17 checks passed
@Givikap120 Givikap120 deleted the catch_nf_penalty branch July 28, 2024 16:05
bdach added a commit to bdach/osu that referenced this pull request Oct 7, 2024
@bdach
Bump difficulty calculator versions
1af464d 
In order for the new star difficulty to be shown to users on the next
release.

catch's difficulty calculator version is not bumped because the only
catch change pending deploy is ppy#28353 and
that affects performance points only.
@bdach bdach mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

@Sorceress4628 Sorceress4628 Sorceress4628 approved these changes

@bastoo0 bastoo0 bastoo0 approved these changes

@Flawnpiece Flawnpiece Flawnpiece approved these changes

Assignees
No one assigned
Labels
area:difficulty ruleset/osu!catch size/XS
Projects
Difficulty calculation changes
Status: Pending Deploy
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Givikap120 @smoogipoo @peppy @Sorceress4628 @bastoo0 @Flawnpiece @bdach